Skip to content

fix(rdf): converge Fuseki state on weekly rebuilds and isolate API latency#28117

Merged
harshach merged 20 commits into
mainfrom
harshach/rdf-fuseki-duplicate-relations
May 16, 2026
Merged

fix(rdf): converge Fuseki state on weekly rebuilds and isolate API latency#28117
harshach merged 20 commits into
mainfrom
harshach/rdf-fuseki-duplicate-relations

Conversation

@harshach
Copy link
Copy Markdown
Collaborator

@harshach harshach commented May 14, 2026

Describe your changes:

RDF Knowledge Graph indexing was duplicating triples and accumulating disk + memory in Fuseki on every run; when Fuseki crash-looped, every entity-write hook blocked synchronously on the unreachable server (no HTTP timeout, 3-retry loop), saturating the bounded AsyncService pool and pushing login latency to ~45 s. The reindex now uses recreateIndex=true on a weekly Saturday cadence, every reconciliation path actually deletes removed relationships, and the Fuseki client has a 2 s connect timeout + circuit breaker so a dead Fuseki can no longer block request threads.

Type of change:

  • Bug fix

High-level design:

Storage-side (stop growth):

  • RdfRepository.createOrUpdate no longer preserves stale relationship triples — the translator is the source of truth and surrounding orchestration rewrites the current set. Also removes a wasted CONSTRUCT round-trip per write.
  • bulkStoreRelationships does per-source-entity DELETE WHERE with a predicate-exclusion FILTER for lineage edges, so removed relationships actually leave the store.
  • RdfRepository.clearAllGlossaryTermRelations() is now wired into RdfIndexApp.initializeJob (the method existed but had no callers).
  • recreateIndex default flipped to true, cron moved to "0 0 * * 6" (Saturday midnight), and reloadOntologies() runs after clearAll() so the ontology graph isn't left empty.
  • Added 2.0.1/{mysql,postgres}/postDataMigrationSQLScript.sql to update existing installed_apps rows; the app loader is insert-only on upgrade.

Connectivity / concurrency (isolate platform from Fuseki health):

  • JenaFusekiStorage HttpClients now use connectTimeout=2s; on ConnectException / ClosedChannelException / HttpConnectTimeoutException we fast-fail instead of retrying. A 5-failure/30 s circuit breaker short-circuits subsequent calls until Fuseki recovers (probed via testConnection which bypasses the breaker).
  • RdfUpdater mutators now go through AsyncService.execute(...) (the existing virtual-thread pool) with a bounded pendingWrites gate (cap 1000, drop-on-overflow with logged warning) so the request thread returns immediately and a dead Fuseki cannot starve AsyncService permits.

Tests:

Unit tests

Extended RdfIndexAppTest:

  • Existing recreateIndex=true test now also verifies reloadOntologies() is called after clearAll().
  • New: clearAllGlossaryTermRelations() is invoked when glossaryTerm is in the entity set AND recreateIndex=false.
  • New: it is NOT invoked when glossaryTerm is absent.

Backend integration tests

  • Not applicable in this PR — the branch currently has a pre-existing es.co.elastic.clients.* shading compile issue unrelated to this work that blocks the module build. Once that is fixed, the planned end-to-end tests (re-run indexer twice → triple count unchanged; remove an edge in MySQL → triple disappears in Fuseki; point RDF endpoint at a closed port → write returns <500ms; recreateIndex=true → ontology graph non-empty after run) should be added.

Manual testing performed

  • Verified diff is syntactically consistent with existing patterns (DELETE/INSERT scaffolding, Entity.GLOSSARY_TERM constant, AsyncService API).
  • Reviewed git stash baseline to confirm pre-existing compile errors are unrelated to these changes.

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.

🤖 Generated with Claude Code


Summary by Gitar

  • RDF transactionality:
    • Combined DELETE and INSERT SPARQL operations into a single atomic transaction in bulkStoreRelationships to prevent partial graph updates.
    • Enforced tempModel.close() to release in-memory graph resources during predicate URI generation.
  • Error handling:
    • Added fallback URIs for broader, narrower, and exactMatch in RdfRepository to maintain cleanup integrity during SettingsCache outages.
    • Optimized bulkAddRelationships to reconcile empty-edge cases correctly while skipping processing when both relationships and sources are empty.
  • Refactoring:
    • Streamlined RdfBatchProcessor to eliminate redundant reconciliation calls and consolidate atomic updates.

This will update automatically on new commits.

…tency

RdfIndexApp ran daily and never reconciled removed relationships, so triples
grew unboundedly across runs. When Fuseki crash-looped on the resulting disk
pressure, every entity-write hook blocked synchronously on the unreachable
server (no HTTP connect timeout, 3-retry loop on ConnectException), saturating
the bounded AsyncService pool and pushing login to ~45s.

Storage-side fixes (stop growth):
- Drop the extractRelationshipTriples "preserve forward" path in
  RdfRepository.createOrUpdate; the translator is the source of truth and the
  surrounding orchestration already rewrites the current relationship set.
  This also removes a wasted CONSTRUCT round-trip per entity write.
- bulkStoreRelationships now does per-source-entity DELETE WHERE with a
  predicate-exclusion FILTER for lineage edges, so relationships that no
  longer exist actually leave the store.
- Wire RdfRepository.clearAllGlossaryTermRelations() into RdfIndexApp's
  initializeJob (the method existed but had no callers).
- Flip recreateIndex default to true and move the cron to Saturday midnight
  ("0 0 * * 6"). Add reloadOntologies() so CLEAR ALL doesn't leave the
  ontology graph empty before indexing starts.
- Include a 2.0.1 post-data migration that updates existing installed_apps
  rows; the app loader is insert-only on upgrade.

Connectivity / concurrency fixes (isolate API latency from Fuseki health):
- Add 2s connectTimeout to every JenaFusekiStorage HttpClient and fast-fail
  on ConnectException / ClosedChannelException / HttpConnectTimeoutException
  instead of retrying. Introduce a 5-failure/30s circuit breaker.
- Route all RdfUpdater mutators through AsyncService.execute with a bounded
  pendingWrites gate (cap 1000, drop-on-overflow with logged warning) so a
  dead Fuseki can no longer block request threads or starve the AsyncService
  pool.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 14, 2026 14:31
@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels May 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make RDF/Fuseki indexing converge more reliably and reduce platform latency impact when Fuseki is unhealthy.

Changes:

  • Changes RDF app defaults to weekly recreate-index runs and adds migrations for existing app rows.
  • Adds Fuseki connection timeout/circuit-breaker handling and async RDF updater submission.
  • Adjusts RDF reindex cleanup paths, ontology reload after clear, and related unit tests.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
openmetadata-service/src/test/java/org/openmetadata/service/apps/bundles/rdf/RdfIndexAppTest.java Adds coverage for ontology reload and glossary relation cleanup behavior.
openmetadata-service/src/main/resources/json/data/appMarketPlaceDefinition/RdfIndexApp.json Updates marketplace default recreateIndex to true.
openmetadata-service/src/main/resources/json/data/app/RdfIndexApp.json Updates app default recreateIndex and weekly cron schedule.
openmetadata-service/src/main/java/org/openmetadata/service/rdf/storage/JenaFusekiStorage.java Adds timeout/circuit-breaker state and relationship reconciliation changes.
openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfUpdater.java Moves RDF mutating hooks to bounded async submission.
openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java Adds ontology reload and removes relationship preservation during entity writes.
openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/rdf/RdfIndexApp.java Wires glossary relation cleanup and ontology reload after full RDF clear.
bootstrap/sql/migrations/native/2.0.1/postgres/postDataMigrationSQLScript.sql Migrates existing PostgreSQL app rows to new RDF app defaults.
bootstrap/sql/migrations/native/2.0.1/mysql/postDataMigrationSQLScript.sql Migrates existing MySQL app rows to new RDF app defaults.

…surface ontology failures

PR #28117 review feedback. Addresses 13 findings across gitar-bot and Copilot:

Storage correctness:
- JenaFusekiStorage.storeEntity now keeps URI-valued triples (relationships)
  and only refreshes literal-valued triples. A metadata-only PATCH would
  otherwise wipe every inter-entity edge until the next weekly recreate-index,
  and async ordering between updateEntity and addRelationship could leave the
  graph missing edges (Copilot #1, #2).
- RdfRepository.removeRelationship wraps the DELETE in the knowledge named
  graph and uses getRelationshipPredicate so the predicate URI matches what
  addRelationship actually wrote (e.g. UPSTREAM → prov:wasDerivedFrom). The
  previous bare DELETE in the default graph was a silent no-op (Copilot #3).
- RdfBatchProcessor now calls a new RdfRepository.clearOutgoingEntityRelationships
  for every entity in the batch, not just those with current edges. An entity
  whose last outgoing relationship was removed in MySQL contributes zero
  RelationshipData entries, so bulkStoreRelationships' per-source DELETE
  never fired for it (Copilot #4).
- bulkStoreRelationships no longer swallows non-connect DELETE errors —
  DELETE WHERE on a source with no edges is a no-op, so exceptions there
  are real failures (malformed SPARQL, auth, server errors) and should
  surface (Copilot #5).

Visibility:
- reloadOntologies() now checks areOntologiesLoaded() after load and throws
  if still empty. OntologyLoader.loadOntologies catches internally, so the
  old reloadOntologies always appeared to succeed (Copilot #6).
- clearAllGlossaryTermRelations rethrows on failure instead of silently
  logging — the indexer's caller can now react to cleanup failures (Copilot #10).
- clearAllGlossaryTermRelations pulls custom predicate URIs from
  GlossaryTermRelationSettings and includes them in the DELETE FILTER. The
  hardcoded list missed any custom predicates an admin configured (Copilot #7).

Quality:
- Set / LinkedHashSet imported instead of using java.util.* fully qualified
  in JenaFusekiStorage and RdfBatchProcessor (gitar-bot #2).
- RdfIndexAppTest uses InOrder to assert clearAll → reloadOntologies
  ordering — a plain verify would have accepted a future change that
  reordered the calls (Copilot #9).
- Documented the residual gap that HttpClient.connectTimeout only bounds
  TCP connect, not request bodies; circuit breaker + bounded pendingWrites
  contain the blast radius (Copilot #8).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@harshach
Copy link
Copy Markdown
Collaborator Author

Addressed all 13 review findings in 9b6e112. Summary:

Storage correctness:

Visibility:

Quality:

Documented gaps:

  • HTTP request-body timeout (Copilot Show successful message for any post or put actions with subtle UX in the buttons #8): Jena's RDFConnection.update() doesn't expose a per-request timeout cleanly. Wrapping in CompletableFuture would change call semantics and we'd lose underlying HTTP cancellation either way. Added a comment near the CONNECT_TIMEOUT constant explaining the gap; the circuit breaker (5 failures → 30s short-circuit) plus the bounded pendingWrites gate in RdfUpdater (drop-on-overflow at 1000) bound the blast radius. Worth a follow-up to plumb QueryExecutionHTTPBuilder.timeout() / UpdateExecHTTPBuilder.timeout() through the connection layer.

Treated as false positive:

  • gitar-bot Create teams page similar to tags #1 (hardcoded predicate URIs in DELETE filter): addLineageWithDetails at RdfRepository.java:346,358 writes the predicate URIs as hardcoded https://open-metadata.org/ontology/UPSTREAM and https://open-metadata.org/ontology/hasLineageDetails (not baseUri-derived). The DELETE filter's hardcoded exclusion correctly matches what's actually stored. Switching the exclusion to use baseUri (as suggested) would BREAK the protection for non-default baseUri configurations because then the filter wouldn't match the still-hardcoded URIs from addLineageWithDetails. The deeper inconsistency — that addLineageWithDetails hardcodes while bulkStoreRelationships' INSERT uses baseUri + "ontology/" — is pre-existing and out of scope for this PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

🟡 Playwright Results — all passed (10 flaky)

✅ 4070 passed · ❌ 0 failed · 🟡 10 flaky · ⏭️ 92 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 755 0 7 14
🟡 Shard 3 780 0 1 7
✅ Shard 4 790 0 0 18
🟡 Shard 5 708 0 1 41
🟡 Shard 6 738 0 1 8
🟡 10 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/KnowledgeCenterList.spec.ts › Knowledge Center List - Test infinite scroll/pagination (shard 2, 2 retries)
  • Features/KnowledgeCenterList.spec.ts › Knowledge Center List - Test add article button (shard 2, 1 retry)
  • Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
  • Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
  • Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

… all filtered

The two EventSubscription-skip tests used verifyNoInteractions on the RDF
repository mock, which was valid before because filtered batches never
touched RDF. The new per-source reconciliation clear in
RdfBatchProcessor.processBatchRelationships now runs for every batch entity
regardless of whether its relationships survive filtering — that's
deliberate, since stale RDF state for those source entities still needs
to be reconciled even when their current MySQL edges all point to excluded
entity types. Switch the assertions to verify clearOutgoingEntityRelationships
is the sole interaction (no bulkAdd, no addRelationship).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 15, 2026 03:37
harshach and others added 2 commits May 15, 2026 10:21
…se it

JenaFusekiStorage (org.openmetadata.service.rdf.storage) lives in a different
package than RdfRepository (org.openmetadata.service.rdf), so the
package-private buildPredicateInList helper introduced in 857c09 couldn't be
called from JenaFusekiStorage.bulkStoreRelationships — CI was failing with:

  [ERROR] JenaFusekiStorage.java:[606,51] buildPredicateInList(Set<String>)
  is not public in RdfRepository; cannot be accessed from outside package

Promote it to public alongside RELATIONSHIP_HOOK_PREDICATES (which is the
only data this helper renders) so the cross-package call resolves. Local
javac across the touched RDF files now reports zero new errors; the only
remaining build failures are the pre-existing es.co.elastic.clients shading
issues unrelated to this PR.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… iteration

bulkStoreRelationships' early-return guard accepts sourcesToReconcile == null
as a valid input, but the subsequent per-source DELETE loop iterates
sourcesToReconcile directly — so a caller passing null with a non-empty
relationships list would skip the guard and crash at the for-loop.

Today no caller hits this path (RdfRepository.bulkAddRelationships always
passes non-null, and the 1-arg default interface method derives a set), but
the null-check in the guard explicitly encodes null as supported, so the
contract should match the iteration. Normalise once after the guard:

    Set<String> effectiveSources =
        sourcesToReconcile != null ? sourcesToReconcile : Set.of();

and use effectiveSources for both the loop and the success-log size.

Local filtered compile passes cleanly (zero NEW errors from RDF files;
remaining errors are the pre-existing es.co.elastic.clients shading mess).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 15, 2026 17:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…lationships 2-arg signature

Three test failures after the Fix-I / atomic-clear-insert changes:

- testProcessBatchRelationshipsStoresResults verified
  `bulkAddRelationships(captor.capture())` (1-arg) but RdfBatchProcessor now
  calls the 2-arg `bulkAddRelationships(relationships, batchSources)` — Mockito
  surfaced this as "different arguments" because the actual call had a
  Set<EntitySourceRef> tail. Updated the verify to
  `bulkAddRelationships(captor.capture(), anySet())`.

- The two event-subscription skip tests previously verified
  `clearOutgoingEntityRelationships(anySet())` as the only interaction; that
  method is no longer called from RdfBatchProcessor (the clear was folded
  into bulkAddRelationships' atomic SPARQL transaction for safety). Replace
  with `verify(mockRdfRepository).bulkAddRelationships(eq(List.of()), anySet())`
  — bulkAdd is still invoked with an empty list to drive the per-source
  reconciliation for the batch entity, even when the only fetched
  relationship pointed at an excluded entity type.

Filtered local compile + test-compile passes cleanly (no NEW errors from RDF
files; only pre-existing es.co.elastic.clients shading errors remain).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- collectTranslatorPredicates over-broad (3249798300): RdfRepository.addRelationship
  passes storeEntity a model loaded from Fuseki PLUS the new relationship, so the
  dynamic walk was pulling hook-managed predicates (om:owns, etc.) into the DELETE
  scope. With async writes, two concurrent additions for the same source could
  each read the old model and each storeEntity wipe the other's relationship.
  Exclude RELATIONSHIP_HOOK_PREDICATES from the walk result (and defensively from
  the static-set union too).

- ForkJoinPool.commonPool starvation (3249798327): runWithTimeout used
  CompletableFuture.supplyAsync's default executor, so a Fuseki that stalls would
  leak workers on the JVM-wide commonPool and starve unrelated CompletableFuture
  / parallel-stream work. Introduce a dedicated virtual-thread executor
  (Thread.ofVirtual().name("rdf-storage-timeout-", 0)) and route all timeout
  wrappers through it — virtual threads are cheap to leak and the circuit breaker
  bounds the pile-up.

- Shrink-to-empty for literal predicates (3249798383): the predicate-scoped DELETE
  no longer caught stale literals when a literal-valued field (description /
  displayName / …) was cleared and the new model simply omitted the triple. Chain
  a "DELETE … FILTER(!isIRI(?o))" pass with the URI-scoped pass so hook-managed
  URI triples stay intact while stale literals get swept on every write.

- UI schema default (3249798439): the UI form schema at
  utils/ApplicationSchemas/RdfIndexApp.json still declared recreateIndex.default
  = false. Flipped to true to match the backend openmetadata-spec schema and the
  install JSON files. (The sibling jsons/applicationSchemas/ is gitignored
  generated output, no source change needed there.)

Local verification before push: spotless:apply, filtered compile + test-compile
(zero new errors), and `mvn test -Dtest='RdfIndexAppTest,RdfPropertyMapperTest,
RdfPredicatePartitionTest,RdfStorageIdempotencyTest'` — 64 tests, 0 failures.

The "buildPredicateInList package-private" finding from the same review
(3249798351) is already addressed in 03c5d4f and surfaces here only because
Copilot reviewed an earlier commit.

The "lineage incremental cleanup" finding (3249798415) is a known architectural
trade-off: addLineageWithDetails handles current lineage rows but removed edges
have no row to trigger a per-edge delete, and adding UPSTREAM/wasDerivedFrom to
RELATIONSHIP_HOOK_PREDICATES would conflict with the inline addLineageWithDetails
call that runs BEFORE bulkAddRelationships in RdfBatchProcessor. The weekly
recreateIndex=true run (the new default) wipes and rebuilds from MySQL, which
reconciles stale lineage; left this thread open as a documented gap rather
than reordering processBatchRelationships in this PR.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 15, 2026 19:02
@harshach harshach requested a review from a team as a code owner May 15, 2026 19:02
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 15, 2026

Code Review ✅ Approved 6 resolved / 6 findings

Implements atomic RDF reconciliation, Fuseki connection timeouts, and circuit breakers to prevent index bloat and cascading API latency. All identified findings regarding resource management and error handling have been resolved.

✅ 6 resolved
Quality: Fully qualified class names used instead of imports in new code

📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/storage/JenaFusekiStorage.java:470
New code in bulkStoreRelationships uses java.util.Set and java.util.LinkedHashSet as fully qualified names (line 470) instead of adding imports. Per the project's coding standards, fully qualified names should be avoided in favor of explicit imports.

Quality: Fully qualified class names in clearAllGlossaryTermRelations

📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java:2546-2548 📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java:2552
Lines 2546-2548 use fully qualified names (org.openmetadata.schema.configuration.GlossaryTermRelationSettings, org.openmetadata.service.resources.settings.SettingsCache, org.openmetadata.schema.settings.SettingsType) instead of imports. Per project conventions, wildcard and fully-qualified names should be avoided — add proper imports at the top of the file.

Edge Case: expandPredicateCurie silently defaults null/empty to relatedTo

📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java:2708-2711
expandPredicateCurie (line 2709-2710) returns "https://open-metadata.org/ontology/relatedTo" for null or empty input. In clearAllGlossaryTermRelations, this means a misconfigured relation type with a null rdfPredicate would cause the cleanup to target relatedTo triples even if the configured type never wrote them — or worse, skip cleaning the actual custom predicate. Since the null case is already guarded by the if (rdfPredicate != null) check at line 2553, this default is unreachable in current code but could silently mask bugs if called from elsewhere.

Quality: tempModel created in loop scope is never closed

📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java:401
At line 401, ModelFactory.createDefaultModel() creates a Jena in-memory Model that is Closeable. While the GC will eventually reclaim it, best practice (and consistency with the rest of the codebase) is to close it in a try-with-resources or finally block. This avoids holding resources longer than necessary, especially if the relationships list is large and getRelationshipPredicate accumulates properties in the model.

Bug: Hardcoded predicate URIs in DELETE filter ignore configurable baseUri

📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/storage/JenaFusekiStorage.java:493-495 📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java:350-351 📄 openmetadata-service/src/main/java/org/openmetadata/service/rdf/storage/JenaFusekiStorage.java:513-515
In bulkStoreRelationships, the SPARQL DELETE WHERE filter hardcodes https://open-metadata.org/ontology/UPSTREAM and https://open-metadata.org/ontology/hasLineageDetails to exclude lineage predicates from deletion. However, the INSERT uses the configurable baseUri field for the ontology prefix (PREFIX om: <baseUri + "ontology/">). If baseUri is configured to anything other than https://open-metadata.org/, the predicates stored in the graph won't match the hardcoded exclusion URIs, causing lineage edges to be incorrectly deleted on every reconciliation run.

The storeRelationship method (single-relationship path) also hardcodes the same ontology URI pattern, so this is consistent within the file — but both paths are broken for non-default baseUri configurations.

...and 1 more resolved from earlier reviews

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.63% (64856/103540) 43.39% (35381/81528) 46.18% (10406/22532)

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants